Skip to content

fix: add HOST_IP support and strict LOG_LEVEL validation to reth entrypoint#1057

Closed
Kewe63 wants to merge 1 commit into
base:mainfrom
Kewe63:fix/reth-entrypoint-host-ip-and-log-level-upstream
Closed

fix: add HOST_IP support and strict LOG_LEVEL validation to reth entrypoint#1057
Kewe63 wants to merge 1 commit into
base:mainfrom
Kewe63:fix/reth-entrypoint-host-ip-and-log-level-upstream

Conversation

@Kewe63
Copy link
Copy Markdown

@Kewe63 Kewe63 commented May 11, 2026

Summary

Implements HOST_IP advertisement for NAT traversal and adds strict LOG_LEVEL validation to the Reth entrypoint.

Problem

  • Reth nodes behind NAT struggled with peer discovery because the external IP was not advertised.
  • The temporary reth node used for historical proofs initialization did not receive the NAT configuration.
  • Unknown LOG_LEVEL values were silently falling back to defaults without notifying the operator.
  • Unvalidated HOST_IP inputs could lead to shell expansion issues.

Solution

  • Implemented a dedicated NAT_ARG that is passed to both the temporary initialization node and the final execution process.
  • Added IPv4 regex validation for HOST_IP for security and robustness.
  • Added a strict case statement for LOG_LEVEL validation that exits with an error on unknown values.

Verification

  • Verified NAT flag propagation to both process instances.
  • Tested LOG_LEVEL validation with invalid inputs.

Impact

Significantly improves P2P connectivity for operators behind NAT and enhances operational reliability through strict input validation.

@cb-heimdall
Copy link
Copy Markdown
Collaborator

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

@github-actions
Copy link
Copy Markdown
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions Bot added the Stale label May 28, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 5, 2026

This pull request was closed because it has been inactive for 5 days since being marked as stale.

@github-actions github-actions Bot closed this Jun 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants